Improve CAST('field' AS CHAR(n)) #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Nicola Galgano <[email protected]>
|
Can you remove the linebreaks between the params please |
wilsonge
reviewed
Dec 2, 2020
Done. |
wilsonge
approved these changes
Dec 2, 2020
Co-authored-by: George Wilson <[email protected]>
|
Wait, I have to fix more spelling errors. |
|
Done. |
|
@wilsonge Do you think that these typos which I've corrected in my last commit are worth to be corrected in the CMS repo in staging, too? |
|
Yes please! |
|
I see they have been already corrected there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #157 (part 1)
Summary of Changes
Port back joomla/joomla-cms#12417 to the framework.
Thanks @alikon for the CMS PR. I've mentioned you as co-author in the commit of this PR here so some credits go to you.
Testing Instructions
See testing instructions of joomla/joomla-cms#12417 .
Documentation Changes Required
No idea.