Add a castAs method #179
Merged
Add a castAs method #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonge
force-pushed
the
feature/castAs
branch
2 times, most recently
from
772b03c
to
c0499e1
Compare
|
@wilsonge Care to rebase this? |
|
tested ok on postgresql 11.5 |
|
conflict apart can we have a response here ? |
wilsonge
force-pushed
the
feature/castAs
branch
from
168e6f1
to
f6c7fb1
Compare
|
Conflicts fixed (hopefully) - they were complicated and then I just clean forgot about this. If the tests pass I think this should be good to merge |
mbabker
reviewed
Nov 17, 2019
wilsonge
force-pushed
the
feature/castAs
branch
4 times, most recently
from
be81226
to
400fafc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method replaces
castAsCharwhich had fallen behind the CMS in terms of support anyhow. This uses the concept proposed by @alikon in joomla/joomla-cms#18961 (comment)Includes tests & docs
Somewhat related is #157 over which matches some of the castAsChar stuff to gain complete sync with the CMS on the
castAsCharmethod