Skip to content

PRO-16379: Parse id from branch and accept lower case in project name #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BanarJoomPro merged 2 commits into from
Dec 30, 2025
Merged

PRO-16379: Parse id from branch and accept lower case in project name #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d536992
Parse id from branch and accept lower case in project name
BanarJoomPro Dec 29, 2025
6d4c778
Update test to support lower and mixed case
BanarJoomPro Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/helpers/__tests__/issue.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ describe('extractIssueNumbers function', () => {

it('should extract issue numbers when surrounded by non-alphanumeric characters', () => {
const input = 'Issue: (ABC-789), Dash-123, Colon:XYZ-456';
const expectedOutput = ['ABC-789', 'XYZ-456'];
const expectedOutput = ['ABC-789', 'DASH-123', 'XYZ-456'];

expect(extractIssueNumbers(input)).toEqual(expectedOutput);
});
Expand Down
4 changes: 4 additions & 0 deletions src/helpers/github.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@ export async function getPullRequestIssueIds(pr: PullRequestType): Promise<strin
extractIssueNumbers(pr.title).map((id) => ids.add(id));
}

if (typeof pr.head?.ref === 'string') {
extractIssueNumbers(pr.head.ref).map((id) => ids.add(id));
}

return [...ids];
}

Expand Down
4 changes: 2 additions & 2 deletions src/helpers/issue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const ISSUE_PATTERN_RE = /(?<![a-zA-Z0-9])[A-Z][A-Z0-9]{1,}-\d+(?![a-zA-Z0-9])/g;
const ISSUE_PATTERN_RE = /(?<![a-zA-Z0-9])[A-Z][A-Z0-9]{1,}-\d+(?![a-zA-Z0-9])/gi;

export function extractIssueNumbers(string: string): string[] {
const result: Set<string> = new Set();
string.match(ISSUE_PATTERN_RE)?.forEach((issue) => result.add(issue));
string.match(ISSUE_PATTERN_RE)?.forEach((issue) => result.add(issue.toUpperCase()));
return [...result];
}