Add option to overwrite the default prefilter for links #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've created this new PR based on the |
|
Hi, @leanbalma sorry for the delay. Would you mind adding a unit test or two so we can get coverage up and I can merge? thanks! |
leanbalma
force-pushed
the
custom-linkify-prefilter
branch
from
66da440 to
77ad443
Compare
leanbalma
force-pushed
the
custom-linkify-prefilter
branch
from
77ad443 to
b344065
Compare
|
Hi @jonschlinkert! I've added the tests. It seems that we are good to go now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intents to fix some issues a few users have been having. For example, #183 and #134. The current implementation also won't linkify some valid links, like just "github.com".
What I did is introduce a new linkifyPrefilter option, which lets the user to write their own prefilter, instead of the default prefilter. The user could also make the function to return true if he/she wants to disable the prefilter.
I haven't written any test yet, but I'll be placed to do it if you agree with this PR.
This PR fixes #183.