Repository navigation
feat: CalVer versioning from git tags, version visible, Linux PR builds (ADR-0013) - #188
Merged
Merged
Conversation
…lds (ADR-0013) Releases are tagged vYYYY.M.MICRO (UTC year + unpadded month, MICRO counts releases within the month from 0; rcs take -rcN). YYYY.MM.DD was rejected: a same-day second release needs a fourth component, which breaks the macOS three-integer CFBundleShortVersionString. The tag is now the only source of truth: - setuptools-scm derives the version (no-guess-dev: exactly the tag on a tag, 2026.11.0.post1.dev3+g<sha> after it) and writes deckd/_version.py at install; it matches only CalVer-shaped tags, skipping verify/61-touch-targets and the v0.0.0-* rehearsals. - The hard-coded 0.0.1 copies are gone (pyproject, __init__, /diag, package.json x2). - The flake passes 0+git.<date>.g<rev> (no .git in the store); exported NixOS/home-manager modules default to the flake's own versioned package via one keyed module, so importing several defines it once. - Release checkouts use full history so the frozen apps carry the tag; the Linux job asserts the tarball's --version equals the tag. - build-linux-portable mounts the main git dir when run from a worktree. Visible in /health, /diag, `deckd --version`, `deckctl --version` / `status`, and the client settings diagnostics. `just release` computes the next tag (scripts/next_version.py, tested), checks the tree is clean and at origin/main, confirms, then tags + pushes. release-linux.yml gains PR builds for Linux packaging paths (build, floor, smoke; never publish), a publish toggle for manual runs, and read-only default permissions, mirroring release-macos.yml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the versioning plan. ADR-0013: CalVer
vYYYY.M.MICRO, with the git tag as the only source of truth.Summary
Scheme.
v2026.11.0,v2026.11.1, … thenv2026.12.0. That's the UTC year, the unpadded month, and a counter of releases within the month starting at 0. Release candidates take-rcNand publish as prereleases.YYYY.MM.DDwas rejected because a second release on the same day would need a fourth number, and macOS'sCFBundleShortVersionStringallows only three.One source. Every version now comes from the git tag:
Visible. The version now appears in
/health(readable before auth, like the rest of it),/diag,deckd --version,deckctl --versionanddeckctl status, and as a "deckd version" row in the client settings diagnostics.Releasing.
CI.
release-linux.ymlnow matches what #186 did for macOS:Release checkouts use full history so the frozen apps see the tag, and the Linux job asserts that the tarball's
--versionequals the tag.Evidence
pytest: 842 passed (+6test_next_version.py, plus version assertions on/health,/diag,--versionanddeckctl status). pyright is clean,tscis clean, and the client unit tests pass (393).pip install -e):verify/…,v0.0.0-test-115(which crashedsetuptools-scmuntil the tag match was narrowed to CalVer-shaped tags), and no.gitat all.just build-linux-portablebuilds in the manylinux container, andbin/deckd --versionprints the git-derived version.nix flake checkpasses.nix build .#deckdthendeckd --versionprints0+git.20261114.gaf60623…. Evaluating the modules confirms that NixOS, home + GNOME imported together, and a user's ownpackageoverride all resolve correctly.Merge Danger
Door: two-way
No releases exist yet. The first
just releasecreatesv2026.11.0.Blast Radius: build/release
"0"so its npm-deps download stays cached across commits, andnpmDepsHashwas updated because the lockfile lost itsversionline.0.post1.devN+unknown.g<sha>) until the first CalVer tag exists. Editable installs show the version from the lastjust setup.app_bundle.pyandpyproject.toml, so the new PR builds get exercised here.