Skip to content

Commit

Permalink
Merge pull request #3 from erkens/grumphp-upgrade-v2
Browse files Browse the repository at this point in the history
Upgrade to new ExtensionInterface for GrumPHP 2.x
  • Loading branch information
jonmldr authored Sep 8, 2023
2 parents 17c960d + e853e30 commit 7deb36f
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 11 deletions.
6 changes: 2 additions & 4 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,8 @@
}
],
"require": {
"php": "^7.3|^8.0"
},
"require-dev": {
"phpro/grumphp": "^1.0"
"php": "^8.1",
"phpro/grumphp": "^2.0"
},
"autoload": {
"psr-4": {
Expand Down
8 changes: 8 additions & 0 deletions config/doctrine-task-extension.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
services:
JonMldr\GrumPhpDoctrineTask\DoctrineSchemaValidateTask:
class: \JonMldr\GrumPhpDoctrineTask\DoctrineSchemaValidateTask
arguments:
- "@process_builder"
- "@formatter.raw_process"
tags:
- { name: grumphp.task, task: doctrine_schema_validate }
7 changes: 5 additions & 2 deletions src/DoctrineSchemaValidateTask.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
use GrumPHP\Runner\TaskResult;
use GrumPHP\Runner\TaskResultInterface;
use GrumPHP\Task\AbstractExternalTask;
use GrumPHP\Task\Config\ConfigOptionsResolver;
use GrumPHP\Task\Context\ContextInterface;
use GrumPHP\Task\Context\GitPreCommitContext;
use GrumPHP\Task\Context\RunContext;
Expand All @@ -30,7 +31,7 @@ public function canRunInContext(ContextInterface $context): bool
/**
* {@inheritdoc}
*/
public static function getConfigurableOptions(): OptionsResolver
public static function getConfigurableOptions(): ConfigOptionsResolver
{
$resolver = new OptionsResolver();
$resolver->setDefaults([
Expand All @@ -44,7 +45,9 @@ public static function getConfigurableOptions(): OptionsResolver
->addAllowedTypes('skip_sync', ['bool'])
->addAllowedTypes('triggered_by', ['array']);

return $resolver;
return ConfigOptionsResolver::fromClosure(
static fn (array $options): array => $resolver->resolve($options)
);
}

/**
Expand Down
9 changes: 4 additions & 5 deletions src/ExtensionLoader.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,10 @@

class ExtensionLoader implements ExtensionInterface
{
public function load(ContainerBuilder $container): void
public function imports(): iterable
{
$container->register('task.doctrine_schema_validate', DoctrineSchemaValidateTask::class)
->addArgument(new Reference('process_builder'))
->addArgument(new Reference('formatter.raw_process'))
->addTag('grumphp.task', ['task' => 'doctrine_schema_validate']);
$configDir = dirname(__DIR__) . '/config';

yield $configDir . '/doctrine-task-extension.yaml';
}
}

0 comments on commit 7deb36f

Please sign in to comment.