Add a dedicated lambda bin
#218
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustworthy
commented
Jan 19, 2025
| @@ -236,7 +237,7 @@ async fn list_inner( | |||
| let votes = q["votes"].as_u64().expect("votes is a number") as f64; | |||
| // max so that even if vote count somehow got to 0, count it as 1 | |||
| let votes = votes.max(1.); | |||
| let exp = (-1. * dt as f64).exp_m1() + 1.; | |||
There was a problem hiding this comment.
clippy yelled at me
rustworthy
commented
Jan 19, 2025
Comment on lines
+204
to
+209
| // NB! If you are creating entries manually via the DynamoDB Web UI (or CLI) | ||
| // when developing and testing, make sure you are putting valid ulids as ids, | ||
| // since the db server will only check that `id` respects the `S` type, and so | ||
| // will not error back to you when you are saving a question (say, via Web UI) | ||
| // with `id="string-that-is-not-valid-ulid"`. | ||
| ulid::Ulid::from_string(id).expect("all ids to be valid ulids in the table") |
There was a problem hiding this comment.
addresses thread
rustworthy
changed the title
--release not speciallambda bin
rustworthy
commented
Jan 19, 2025
| cargo lambda build --release --arm64 | ||
| cargo lambda deploy --env-var RUST_LOG=info,tower_http=debug,wewerewondering_api=trace --profile qa | ||
| cargo lambda build --release --arm64 --bin lambda | ||
| cargo lambda deploy --env-var RUST_LOG=info,tower_http=debug,lambda=trace --profile qa --binary-name lambda |
There was a problem hiding this comment.
lambda=trace might be a bit ambiguous, but lambda here is the app's name
rustworthy
changed the title
lambda binlambda bin
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first iteration on #202
I have not found a way to provide flags/args to the lambda runtime, they just taking a
bootstrapbinary from us and that's it.So what I am suggesting instead, is to locate the core logic in the lib and have numerous binaries - two for now. The default bin will be binding to a socket, while the
--bin lambdawill produce a lambda-layered app ready for AWS Lambda runtime. This has a benefit of only including the code we need to the default binary and not adding lambda runtime specific stuff.We will still need logic for parsing command line args for the default binary (to accomplish the testing aspect of #202), but I think we could address it in a dedicated PR.
P.S.: I am suggesting to put auxiliary functions to the
utilsmodule