Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add showDragHandle Parameter to Get.bottomSheet #3113

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add showDragHandle Parameter to Get.bottomSheet #3113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af9b489
added showDragHandle param
egortabula May 28, 2024
ead7c69
Add documentation for `showDragHandle` parameter
egortabula May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions lib/get_navigation/src/bottomsheet/bottomsheet.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ class GetModalBottomSheetRoute<T> extends PopupRoute<T> {
this.modalBarrierColor,
this.isDismissible = true,
this.enableDrag = true,
this.showDragHandle,
required this.isScrollControlled,
super.settings,
this.enterBottomSheetDuration = const Duration(milliseconds: 250),
Expand All @@ -35,6 +36,17 @@ class GetModalBottomSheetRoute<T> extends PopupRoute<T> {
final Clip? clipBehavior;
final Color? modalBarrierColor;
final bool isDismissible;

/// A parameter to control the visibility of a drag handle in the bottom sheet.
///
/// When `showDragHandle` is set to `true`, a drag handle will be displayed at the top
/// of the bottom sheet, allowing users to easily identify and interact with the sheet
/// by dragging it. This is particularly useful for enhancing the user experience in
/// applications where intuitive UI interactions are important.
///
/// When `showDragHandle` is set to `false`, the drag handle will be hidden. By default,
/// the drag handle is hidden to maintain backward compatibility with existing implementations.
final bool? showDragHandle;
final bool enableDrag;
// final String name;
final Duration enterBottomSheetDuration;
Expand Down Expand Up @@ -105,6 +117,8 @@ class GetModalBottomSheetRoute<T> extends PopupRoute<T> {
clipBehavior: clipBehavior,
isScrollControlled: isScrollControlled,
enableDrag: enableDrag,
showDragHandle: showDragHandle ??
(enableDrag && (sheetTheme.showDragHandle ?? false)),
),
),
);
Expand All @@ -124,6 +138,7 @@ class _GetModalBottomSheet<T> extends StatefulWidget {
this.isScrollControlled = false,
this.enableDrag = true,
this.isPersistent = false,
this.showDragHandle,
});
final bool isPersistent;
final GetModalBottomSheetRoute<T>? route;
Expand All @@ -133,6 +148,7 @@ class _GetModalBottomSheet<T> extends StatefulWidget {
final ShapeBorder? shape;
final Clip? clipBehavior;
final bool enableDrag;
final bool? showDragHandle;

@override
_GetModalBottomSheetState<T> createState() => _GetModalBottomSheetState<T>();
Expand Down Expand Up @@ -187,6 +203,7 @@ class _GetModalBottomSheetState<T> extends State<_GetModalBottomSheet<T>> {
shape: widget.shape,
clipBehavior: widget.clipBehavior,
enableDrag: widget.enableDrag,
showDragHandle: widget.showDragHandle,
)
: Scaffold(
bottomSheet: BottomSheet(
Expand All @@ -203,6 +220,7 @@ class _GetModalBottomSheetState<T> extends State<_GetModalBottomSheet<T>> {
shape: widget.shape,
clipBehavior: widget.clipBehavior,
enableDrag: widget.enableDrag,
showDragHandle: widget.showDragHandle,
),
)),
),
Expand All @@ -223,6 +241,7 @@ class _GetPerModalBottomSheet<T> extends StatefulWidget {
this.clipBehavior,
this.isScrollControlled = false,
this.enableDrag = true,
this.showDragHandle,
});
final bool? isPersistent;
final GetModalBottomSheetRoute<T>? route;
Expand All @@ -232,6 +251,7 @@ class _GetPerModalBottomSheet<T> extends StatefulWidget {
final ShapeBorder? shape;
final Clip? clipBehavior;
final bool enableDrag;
final bool? showDragHandle;

@override
// ignore: lines_longer_than_80_chars
Expand Down Expand Up @@ -290,6 +310,7 @@ class _GetPerModalBottomSheetState<T>
shape: widget.shape,
clipBehavior: widget.clipBehavior,
enableDrag: widget.enableDrag,
showDragHandle: widget.showDragHandle,
)
: Scaffold(
bottomSheet: BottomSheet(
Expand All @@ -306,6 +327,7 @@ class _GetPerModalBottomSheetState<T>
shape: widget.shape,
clipBehavior: widget.clipBehavior,
enableDrag: widget.enableDrag,
showDragHandle: widget.showDragHandle,
),
)),
),
Expand Down