Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2705 fix #3104

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified .DS_Store
Binary file not shown.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## [5.0.0-release-candidate-6]

-Fix Snackbar, upgrade to flutter 3.22 @Aniketkhote, improve parse route @korutx, fix popScope @wowbox, improve defaultDialog @leeyi, add support to wasm compilation @Ty, fix typos @CodeWithEmad, fix snackbar cancel @seungsuyoo update GetConnect @DaZealous and @ wheeOs, add bengali language @aratheunseen, fix lint issues: @MuhammamdArslanKhan

## [5.0.0-release-candidate-5]

-Fix nested route issues, fixed issues in the latest flutter version
Expand Down
4 changes: 2 additions & 2 deletions example_nav2/android/local.properties
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
sdk.dir=C:\\Users\\anike\\AppData\\Local\\Android\\sdk
flutter.sdk=C:\\flutter
sdk.dir=/Users/jonatasborges/Library/Android/sdk
flutter.sdk=/Users/jonatasborges/flutter
Binary file added lib/.DS_Store
Binary file not shown.
3 changes: 2 additions & 1 deletion lib/get_connect/http/src/http/html/http_request_html.dart
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ class HttpRequestImpl implements IClient {
reader.onLoad.first.then((_) async {
var bodyBytes = (reader.result as List<int>).toStream();

if(request.responseInterceptor != null) throw 'response interception not implemented for web yet!';
if (request.responseInterceptor != null)
throw 'response interception not implemented for web yet!';

/*
TODO to be implemented like in http_request_io.dart
Expand Down
13 changes: 7 additions & 6 deletions lib/get_navigation/src/routes/default_transitions.dart
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,13 @@ import 'circular_reveal_clipper.dart';

class LeftToRightFadeTransition {
Widget buildTransitions(
BuildContext context,
Curve? curve,
Alignment? alignment,
Animation<double> animation,
Animation<double> secondaryAnimation,
Widget child) {
BuildContext context,
Curve? curve,
Alignment? alignment,
Animation<double> animation,
Animation<double> secondaryAnimation,
Widget child,
) {
return SlideTransition(
position: Tween<Offset>(
begin: const Offset(-1.0, 0.0),
Expand Down
3 changes: 1 addition & 2 deletions lib/get_navigation/src/routes/get_transition_mixin.dart
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ class GetBackGestureDetectorState<T> extends State<GetBackGestureDetector<T>> {
)
},
);

return Stack(
fit: StackFit.passthrough,
children: [
Expand Down Expand Up @@ -361,7 +360,7 @@ Cannot read the previousTitle for a route that has not yet been installed''',
Animation<double> animation,
Animation<double> secondaryAnimation,
Widget child, {
bool limitedSwipe = false,
bool limitedSwipe = true,
double initialOffset = 0,
}) {
// Check if the route has an animation that's currently participating
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: get
description: Open screens/snackbars/dialogs without context, manage states and inject dependencies easily with GetX.
version: 5.0.0-release-candidate-5
version: 5.0.0-release-candidate-6
homepage: https://github.com/jonataslaw/getx

environment:
Expand Down