fix: zip file with hidden directories or __MACOSX directory #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(zipReader): filter hidden dir and __MACOSX dir to avoir duplicate .shp
feat: github action
Atsilbunik rebase
fix: adapt the current documentation to karnott organisation
fix(sequentialreader): fix panic because of nil pointer
fix: error on empty array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compressing files with Mac OS create a
__MACOSXdirectory containing files metadata.With these files, we have duplicate
.shpfiles and the library raises an error here: https://github.com/jonas-p/go-shp/blob/master/zipreader.go#L43To fix it, we need to filter this directory (and hidden directories)