Skip to content

Add date format option with tests #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add date format option with tests #188

wants to merge 1 commit into from

Conversation

aydinomer00
Copy link
Contributor

  • Add Date struct with DateOnly flag
  • Implement custom date formatting for Notion API
  • Add comprehensive test coverage
  • Fix timezone formatting in FormatForNotion
  • Handle null values in UnmarshalJSON
  • Closes Option for choosing the Date format #177

@aydinomer00
Add date format option with tests
78b0f25 
- Add Date struct with DateOnly flag
- Implement custom date formatting for Notion API
- Add comprehensive test coverage
- Fix timezone formatting in FormatForNotion
- Handle null values in UnmarshalJSON
- Closes jomei#177
@wolveix
Copy link
Contributor

wolveix commented Oct 1, 2025

@aydinomer00 this would be great to have :D Before @jomei has time to review it (hopefully soon?), here were my thoughts:

  • I don't think it makes sense to move these into a new pkg/models directory when the rest of the repo doesn't already follow that structure
  • Following the conventions of the rest of the library, date.go and date_object.go should be under one file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option for choosing the Date format
2 participants
@aydinomer00 @wolveix