Refactor the Discord Api Helper to use the RateLimiter #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Phpstan fails on the missing typehint on $client property 👼 |
welcoMattic
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #167
The HTTP Client we use have a ratelimiter: https://github.com/restcord/restcord/blob/master/src/RateLimit/RateLimiter.php
By default the state is stored in memory.
Our previous implementation was always rebuiling a new Client, so in the extractForGuild loop, it was always a fresh client and fresh rate limiter without the informations from the previous request.
This PR use always the same Client and that should allow us to benefit from the RateLimiter for user extraction AND message sending.