Repository navigation
Conversation
The workflow was entirely commented, which GitHub reports as a workflow file issue: a failed run on every push, on every branch. It is now a real workflow, whose job is skipped in docker-starter itself (nothing to deploy). "castor init" removes this condition instead of uncommenting the file, the result in projects is the same. As a bonus, Dependabot can now update its actions.
"castor init" removed the whole .github directory but the build-push workflow, so every project had to rebuild its CI from docker-starter's one. They all ended up with the same files: ci.yml without the PHP versions matrix and the docker-starter tests, cache.yml without DS_PHP_VERSION nor the hardcoded registry, and the composer and docker ecosystems in dependabot.yml. The workflows now mark what only tests docker-starter itself with "docker-starter only" blocks, which "castor init" removes: the rest is kept as the CI of the project. The same mechanism disables the build-push job in docker-starter. Also: * REGISTRY comes from the repository name, in every workflow * cache.yml no longer pins DS_PHP_VERSION (it was the default version) * Dependabot also updates the QA tools and the base Docker images * 4 spaces indentation in every workflow, like ci.yml
lyrixx
changed the title
castor init
… is true Not every project deploys these images: the build-push job now only runs when the PUSH_PRODUCTION_IMAGES repository variable is "true", disabled by default. It replaces the "if: false" docker-starter only block, the variable is not defined in docker-starter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
castor initremoved the whole.github/directory butbuild-push.yml, so every project rebuilt its CI from docker-starter's one, always the same way:ci.ymlwithout the PHP versions matrix and the docker-starter tests,cache.ymlwithoutDS_PHP_VERSIONand the hardcoded registry, plus the composer and docker ecosystems independabot.yml.Now the workflows mark what only tests docker-starter itself with
# >>> docker-starter only/# <<< docker-starter onlyblocks, whichcastor initremoves. The rest is kept as the CI of the project.This also fixes the red
build-push.ymlstatus on every push: the file was entirely commented, which GitHub reports as an invalid workflow. It's now a real workflow, whose job only runs when thePUSH_PRODUCTION_IMAGESrepository variable istrue.Also:
REGISTRYcomes from the repository name in every workflowcache.ymlno longer pinsDS_PHP_VERSION(it was the default version)PUSH_PRODUCTION_IMAGESrepository variable istrue(disabled by default, and in docker-starter itself)The required checks of docker-starter keep their names (
Test with PHP 8.x).