Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 229/connecting stripe account #230

Open
wants to merge 49 commits into
base: live
Choose a base branch
from
Open

Issue 229/connecting stripe account #230

wants to merge 49 commits into from

Conversation

ilirhushi
Copy link
Collaborator

In this PR is integrated Stripe Onboarding

Closes: #229 #223

@github-actions
Copy link

github-actions bot commented Nov 12, 2020 •
edited
Loading

Visit the preview URL for this PR (updated for commit 8854943):

https://joie-app--pr230-issue-229-connecting-fwpcrsgr.web.app

(expires Mon, 07 Dec 2020 19:08:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@ilirhushi ilirhushi linked an issue Nov 12, 2020 that may be closed by this pull request
Collect payments then pay out #223
Open
@ilirhushi ilirhushi self-assigned this Nov 12, 2020
@ilirhushi ilirhushi added the enhancement New feature or request label Nov 12, 2020
ilirhushi and others added 24 commits November 13, 2020 10:41
@ilirhushi
#229 / :construction: preparing stripe onboarding
710e38d
@ilirhushi
Merge branch 'live' of https://github.com/joie/joie-web-app into issu…
d11b8d6 
…e-229/connecting-stripe-account
@ilirhushi
#229 / :construction: working on stripe integration
59b1641
@ilirhushi
Merge branch 'live' of https://github.com/joie/joie-web-app into issu…
ba5eba7 
…e-229/connecting-stripe-account
@ilirhushi
#229 / minor fix
470c062
@yinonov
stripe icon conventional export
e6ddba3
@ilirhushi
#229 / :construction: working with Stripe account
13e6ee6
@ilirhushi
#229 / :construction: working with Stripe account
9cb15b7
@ilirhushi
Merge branch 'live' of https://github.com/joie/joie-web-app into issu…
db30c67 
…e-229/connecting-stripe-account
@ilirhushi
Merge branch 'issue-229/connecting-stripe-account' of https://github.…
00e6d0f 
…com/joie/joie-web-app into issue-229/connecting-stripe-account
@ilirhushi
Merge branch 'issue-229/connecting-stripe-account' of https://github.…
7bf200c 
…com/joie/joie-web-app into issue-229/connecting-stripe-account
@ilirhushi
#229 / :construction: Stripe added function to disconnect the account
31abd8e
@ilirhushi
#229 / :construction: Stripe working on account connecting & disconne…
83bcf86 
…cting
@ilirhushi
Merge branch 'live' of https://github.com/joie/joie-web-app into issu…
f6bb84c 
…e-229/connecting-stripe-account
@ilirhushi
#229 / commeted the option to disconnect from stripe account
3283dc2
@ilirhushi
#229 / :construction: working on adjusting the enrolment for paymentI…
f3e550d 
…ntent
@yinonov
updated firebaseui version
440f567
@ilirhushi
#229 / refactored the logic of stripe customer
2825df9
@ilirhushi
#229 / refactored the logic of stripe
620d0ec
@ilirhushi
#229 / refactored the logic of stripe customer
4477865
@ilirhushi
#229 / added Stripe model
66e6bfb
@ilirhushi
Merge branch 'live' of https://github.com/joie/joie-web-app into issu…
6d51160 
…e-229/connecting-stripe-account

# Conflicts:
#	apps/firebase-cloud-functions/src/interfaces.ts
#	functions/package-lock.json
#	functions/package.json
#	functions/src/interfaces.ts
#	libs/schemes/src/lib/models/interfaces.model.ts
#	package-lock.json
@ilirhushi
Merge branch 'live' of https://github.com/joie/joie-web-app into issu…
0844677 
…e-229/connecting-stripe-account

# Conflicts:
#	apps/firebase-cloud-functions/src/stripe.ts
#	package-lock.json
@ilirhushi
update package-lock.json
9c189a5
@ilirhushi
Merge branch 'live' of https://github.com/joie/joie-web-app into issu…
92ec1db 
…e-229/connecting-stripe-account
@ilirhushi
#229 / adusted the serverside intefaces
010ed34
@ilirhushi
#229 / adusted the serverside intefaces
a0e8b4a
@ilirhushi
#229 / :construction: working on stripe charge & transfer
3970d37
@ilirhushi
#229 / :construction: working on stripe charge & transfer
f40e9f3
@ilirhushi
#229 / :construction: working on stripe charge & transfer
1f2b4dc
@ilirhushi
#229 / :construction: working on stripe charge & transfer
07128f2
@ilirhushi
#229 / :construction: working on stripe charge & transfer
bd056bb
@ilirhushi
#229 / :construction: working on stripe charge & transfer
b0a20e7
@ilirhushi
Merge branch 'live' of https://github.com/joie/joie-web-app into issu…
549ac3f 
…e-229/connecting-stripe-account
@ilirhushi
#229 / support stripe payment customer -> account for the moment
90911e1
@ilirhushi
#229 / support stripe payment customer -> account for the moment
e60f66d
@ilirhushi
#229 / minor refactor
df27a92
yinonov
yinonov requested changes Nov 27, 2020
View reviewed changes
apps/firebase-cloud-functions/src/session.ts Outdated Show resolved Hide resolved
apps/joie/src/app/account/account-banking/account-banking.component.ts Outdated Show resolved Hide resolved
apps/joie/src/app/account/account-banking/account-banking.component.html Show resolved Hide resolved
apps/joie/src/app/account/account-banking/account-banking.component.html
</ng-template>


<ng-template #notSpinning>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apps/joie/src/app/shared/components/payment-source

The above component was responsible adding payment source. It is used outside the scope of account page as well

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yinonov sorry didn't understand this, can you help me understand what should I do here, thanks

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/joie/joie-web-app/blob/live/apps/joie/src/app/shared/components/payment-source/payment-source.component.ts

I mean that this file, payment-source.component.ts, is already doing this work of adding the payment resource, so I'm not sure why it is also happening here in the account banking.

I suggest we bind both -
the original payment-source.component.ts will be responsible to send payment method details and send to stripe, and emit token upon success.
account banking will just use that payment source.

lets discuss it...

apps/joie/src/app/services/stripe/stripe.service.ts Outdated Show resolved Hide resolved
firestore.rules Show resolved Hide resolved
firestore.rules Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yinonov yinonov yinonov requested changes

Assignees

@ilirhushi ilirhushi

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connecting with Stripe Account Collect payments then pay out
2 participants
@ilirhushi @yinonov