Skip to content

fix: correct nav header alignment and table border gaps (supersedes #449) #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: correct nav header alignment and table border gaps (supersedes #449) #450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f6edc4
Fix double and broken horizontal lines in tables
Traven-B Sep 4, 2025
eb09992
Fix misalignment of site title and navigation links
Traven-B Sep 6, 2025
7a7bccd
chore(variables): remove unused $padding-top variable
Traven-B Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 35 additions & 1 deletion _sass/_header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,44 @@
font-size: $h2;
}

// // original -- does not work
// // if you leave as is, in the
// // _media-queries.scss partial add
// // padding-top: 0;
// // to the .site-nav rule inside the media query
// // for an alternate fix

// .site-nav { // not working
// padding-top: $nav-padding; // not working
// } // not working

// // we could just remove the .site-nav rule here
// // but in past incarnations, Jan 2019 on the wayback machine
// // by inspection this worked, we had just ` margin-top: $space-2; `
// // though margin-top: 0; seems to be working, go figure.
// // or as I say, elminate the whole rule at this location in the file
// //
// // this rule is good
.site-nav {
padding-top: $nav-padding;
margin-top: $space-2;
}

// // If we do that, we want to remove or
// // rename the $nav-padding; variable.
// // So there's also a separate commit to remove it.

// // this would work also, use $nav-padding instead of #space-2
// // still setting margin-top instead of padding-top
// .site-nav {
// margin-top: $nav-padding;
// }

// // an additional tweak, in _media-queries.scss
// // you can lift the left nav text upwards by
// // changing the ` .site-header .site-nav ` rule
// // margin-top: .25rem;
// // to something like .2, .15, ..., .05rem;

.site-header nav a {
color: $nav-color;
}
Expand Down
1 change: 1 addition & 0 deletions _sass/_tables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
*/

table {
border-collapse: collapse;
width: 100%;
max-width: 100%;
margin-bottom: 1.5rem;
Expand Down
1 change: 0 additions & 1 deletion _sass/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ $header-font-weight: 300;
// Nav
$nav-color: $mid-gray;
$nav-link-color: #444;
$nav-padding: $space-2;
$nav-link-padding-x: $space-2;
$nav-link-border-bottom: 2px solid #444;
$nav-active-border-bottom: 1px solid $light-gray;
Expand Down