Good feedback

Signed-off-by: Johnny Bieren <[email protected]>

JenkinsfileTrigger

@@ -106,7 +106,7 @@ node('master') {
                                 # If $? -eq 0, we care about package
                                 if [ $CHKR_RC -eq 0 ]; then
                                     valid=1
-                                # If $? -eq 2, upstream package list didnt exist so use legacy method to check
+                                # If $? -eq 2, upstream package list didn't exist so use legacy method to check
                                 elif [ $CHKR_RC -eq 2 ]; then
                                     for package in $(cat ${PROJECT_REPO}/config/package_list); do
                                         if [ "${package}" = "${fed_repo}" ]; then

utils/package_checker.py

@@ -3,8 +3,8 @@
 import sys
 import os.path
 
-# Exit 2 if upstream package list doesnt exist
-# Exit 1 if file exists, but package isnt in the list
+# Exit 2 if upstream package list doesn't exist
+# Exit 1 if file exists, but package isn't in the list
 
 jsonpath = 'fedora-atomic/fedora-atomic-host-base.json'
 
@@ -13,15 +13,16 @@
     print("Could not find upstream package json file")
     sys.exit(2)
 
-jsonfile = open(jsonpath, 'r').read()
-atomicjson = json.loads(jsonfile)
 mypackage = sys.argv[1]
 
+with open(jsonpath, 'r') as f:
+    atomicjson = json.load(f)
+
 # Check if package exists in the json file
 # Check both all packages and x86_64 specific packages
 if mypackage in atomicjson["packages"] or mypackage in atomicjson["packages-x86_64"]:
     print ("Package of interest!")
     sys.exit(0)
-
+    
 # Fail if not
 sys.exit(1)