Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Pin tox and uv versions, to fix CI (#335)" #336

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

john-kurkowski
Copy link
Owner

@john-kurkowski john-kurkowski commented Aug 20, 2024

Instead of #335's rollback of tool versions, trying to roll forward. This library no longer supports Python 3.8, so the CI issue with newer tool versions no longer happens.

Changes

  • Drop PyPy 3.8 from CI
    • It's causing issues with uv in CI that aren't worth hoop jumping. PyPy 3.8 hasn't received updates in years. CPython 3.8's EOL is 2024-10-31.
  • Thanks to upstream changes, this PR just contains a revert

TODO

  • Wait for upstream CPython 3.8 to be EOL 2024-10-31?
  • Remove noisy commits

@john-kurkowski john-kurkowski changed the title Work around pypy38: skipped error, in CI Work around pypy38: skipped error, in newer tox and uv, in CI Aug 21, 2024
Prefer to roll forward with newer versions of these tools. This library no longer supports Python 3.8, so the CI issue with newer tool versions no longer happens.

This reverts commit b7f5aae.
@john-kurkowski john-kurkowski changed the title Work around pypy38: skipped error, in newer tox and uv, in CI Revert "Pin tox and uv versions, to fix CI (#335)" Nov 4, 2024
@john-kurkowski john-kurkowski marked this pull request as ready for review November 4, 2024 23:25
@john-kurkowski john-kurkowski merged commit 5f5cb40 into master Nov 4, 2024
21 checks passed
@john-kurkowski john-kurkowski deleted the automatic-uv branch November 4, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant