Increase typecheck aggression

pyproject.toml

@@ -63,10 +63,7 @@ write_to = "tldextract/_version.py"
 version = {attr = "setuptools_scm.get_version"}
 
 [tool.mypy]
-check_untyped_defs = true
-disallow_incomplete_defs = true
-disallow_untyped_calls = true
-disallow_untyped_defs = true
+strict = true
 
 [tool.pytest.ini_options]
 addopts = "--doctest-modules"

tests/cli_test.py

@@ -27,7 +27,7 @@ def test_cli_parses_args(monkeypatch: pytest.MonkeyPatch) -> None:
 
 
 def test_cli_posargs(
-    capsys: pytest.CaptureFixture, monkeypatch: pytest.MonkeyPatch
+    capsys: pytest.CaptureFixture[str], monkeypatch: pytest.MonkeyPatch
 ) -> None:
     """Test CLI with basic, positional args."""
     monkeypatch.setattr(
@@ -42,7 +42,7 @@ def test_cli_posargs(
 
 
 def test_cli_namedargs(
-    capsys: pytest.CaptureFixture, monkeypatch: pytest.MonkeyPatch
+    capsys: pytest.CaptureFixture[str], monkeypatch: pytest.MonkeyPatch
 ) -> None:
     """Test CLI with basic, positional args, and that it parses an optional argument (though it doesn't change output)."""
     monkeypatch.setattr(

tldextract/suffix_list.py

@@ -9,7 +9,7 @@
 from typing import cast
 
 import requests
-from requests_file import FileAdapter  # type: ignore[import]
+from requests_file import FileAdapter  # type: ignore[import-untyped]
 
 from .cache import DiskCache
 

tldextract/tldextract.py

@@ -353,7 +353,10 @@ class Trie:
     """Trie for storing eTLDs with their labels in reverse-order."""
 
     def __init__(
-        self, matches: dict | None = None, end: bool = False, is_private: bool = False
+        self,
+        matches: dict[str, Trie] | None = None,
+        end: bool = False,
+        is_private: bool = False,
     ) -> None:
         """TODO."""
         self.matches = matches if matches else {}