Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added function to handle bullet list request #70

Closed
wants to merge 1 commit into from

Conversation

cyai
Copy link

@cyai cyai commented Dec 4, 2023

Description

I have added a function which in the src/lib/markdown/markdown.ts file to handle bullet list in. markdown request. This PR will add a new feature to implement bullet list in markdown programmatically.

References

n/a

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in Slab
  • I have updated or added public documentation
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not main

Comment on lines +26 to +29
export function bulletList(value: string) {
return `- ${value}`;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cyai thanks for the contribution but we already have support for bullet lists: https://github.com/joggrdocs/tempo/blob/main/src/lib/Document.ts#L382

There are couple of issues open i.e. #13 if you wanted to take a stab. You could also comment/ask questions since the issue is a bit light (we probably need to scope out GFM support).

@zrosenbauer
Copy link
Member

Closing as we already support this: https://github.com/joggrdocs/tempo/blob/main/src/lib/Document.ts#L382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants