-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitLabRenderer #316
base: master
Are you sure you want to change the base?
Add GitLabRenderer #316
Conversation
An initial attempt at creating a renderer using the GitLab API. Authentication has not yet been implemented, so the `--context` option can only be used with public repositories.
There are now multiple backends that can be used, so picking one using `render_backend` would seem to be more useful than having a binary "offline or not" option.
Provide the ability to make use of the alternate backend renderers like GitLabRenderer.
Thought I would add a |
I do not maintain this repo, but thanks for this PR that adds a useful feature ! I've just tested it and it works fine:
|
👎 Do not merge. This breaks configuration. 👎 The GitLab rendering works but this, as it is, breaks the ability to use |
@ericfrederich yeah, this was only meant as a proof-of-concept. I didn't want to spend too much time on it if there was no chance of it being merged. Unfortunately is seem the projects doesn't seem to have been active for a while, so 🤷 |
I think it's a worthy feature. I'd like to render my Markdown stuff locally without making commits and without sending confidential information over the internet to GitHub. |
Thanks for this PR. I found that KaTeX is not being rendered. Is that a supported feature? |
GitLab now requires authentication to access the MarkDown API. Adding Otherwise this works great! Hopefully it makes it in officially one day. Thank you. |
An initial attempt at creating a renderer using the GitLab API. Authentication has not yet been implemented, so the
--context
option can only be used with public repositories.This is mainly meant as some initial work to see if there is interest in the feature. I assume the next steps would be to implement some sort of
--renderer
options to enable theGitLabRenderer
, add support for authentication, and tests.