This repository was archived by the owner on Nov 7, 2023. It is now read-only.
Refactored, standarised #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0. Converted all the tabs to 4 space 1. Added comments to every (e*v*e*r*y) class and method 2. Renamed methods and variables to match pep8 3. ommision_rules made class variable instead of instance variable 4. Tried to distinguish between public and private methods, prepending _ to private methods 5. Add _check_pad since every pad must be checked against the same criteria which_pad is used for debugging reasons 6. Add password arguement in __init__ (You don't usually change the password) 7. Convert _get_digraphs to a generator and wrote sleekier encrypt and decrypt 8. Removed some unnecessary parentheses in _encrypt/decrypt_digraph 9. Broke exception message errors in many lines and thus produce a very bad result of leaving too many spaces in them... Must fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Liked your work, thought to make it more elegant. Basically changed all the names, added comments
EVERYWERE, made a couple new methods, modified _create_digraphs as a generator.