Open
Conversation
Owner
|
Nice feature! Unless I'm missing something I think you accidentally added some temporary files from your editor (ending with ~) Could you remove them and squash? |
Author
|
Oh!... I am still new to Ruby. Can you tell me where this method get_input_number is. |
Author
|
I will remove the temporary file and upload ASAP |
Owner
|
Regarding the get_input_number, in the validate method you use the get_input_number method, but in the calculate method you seem to reimplement it? |
Author
|
Oops..I will correct it and upload. That has been a silly mistake... |
Owner
|
No worries mate, just make a new commit and squash your branch and then force push it. http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html Thanks! |
joeljunstrom
force-pushed
the
master
branch
from
359f68e to
6d80d20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a CLI.