Skip to content

Fix: stop counting non-Basic auth schemes and malformed tokens as failed attempts #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joelbyford merged 2 commits into from
Mar 5, 2026
Merged

Fix: stop counting non-Basic auth schemes and malformed tokens as failed attempts #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0495fa8
Initial plan
Copilot Mar 5, 2026
d6d793c
Fix: only register failed attempts for valid Basic credential submiss…
Copilot Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions BasicAuth.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,13 +116,8 @@ public async Task Invoke(HttpContext context)
return;
}

if (!TryGetCredentials(context, out string username, out string password, out bool hadAuthorizationHeader))
if (!TryGetCredentials(context, out string username, out string password))
{
if (hadAuthorizationHeader)
{
RegisterFailedAttempt(clientKey, null, now);
}

WriteUnauthorizedResponse(context);
return;
}
Expand Down Expand Up @@ -154,18 +149,16 @@ public bool IsAuthorized(string username, string password)
return SecureEquals(expectedPassword, password);
}

private bool TryGetCredentials(HttpContext context, out string username, out string password, out bool hadAuthorizationHeader)
private bool TryGetCredentials(HttpContext context, out string username, out string password)
{
username = string.Empty;
password = string.Empty;
hadAuthorizationHeader = false;

if (!context.Request.Headers.TryGetValue(HttpAuthorizationHeader, out var authorizationValues))
{
return false;
}

hadAuthorizationHeader = true;
string authorizationHeader = authorizationValues.ToString();
if (string.IsNullOrWhiteSpace(authorizationHeader))
{
Expand Down