-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Crow Facts for #298 #316
base: master
Are you sure you want to change the base?
Conversation
Hello @yedhink ! Can you do two things? Can you take the latest codebase and submit this again? Also, can you check some facts to see that they work independently of seeing the other crow facts? Pending that this all looks good. Crows are amazing! |
@yedhink are you still here? I want to take these facts because they are very good, but significant work has been done since you submitted this PR. Are you able to rebase and complete the required changes? |
Sorry for being very late. Little bit of exams and stuff. Hope you can understand :). By the way i hope I have fixed what you have asked for. |
Oh man, this is so close to being ready, but there are some conflict markers left in. One final edit? :) |
yes. tell me what's to be corrected? |
ahh any problems with merging this? |
Removed conflict markers
Yeah, I'm sorry buddy, still a few things. One issue I've just noticed is that the facts need to work independently of each other. So each fact must have the word "crow" in. |
entry for #298