Use transients as storage as a fallback. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Joe;
I've been using Time-Stack to do some profiling of a page that isn't HTML - so solutions like debug-bar don't work for me. Time-Stack has worked really well - so thanks :)
However - I wanted to profile the code as run WITH and WITHOUT an object cache as many of the users running the code in question won't be using an object cache.
The attached PR makes the plugin fallback on transients for storage if neither APC, or an external object cache are available meaning it can be used without APC/Memcache.
This WorksForMe[tm], but I'm not sure if there was a deliberate reason not to use transients and insist on external cache - maybe some issue I haven't hit yet?
Comments / feedback welcome - thanks!