feat(MPM-708): drop php7.4 support (#45)

Co-authored-by: Marko <[email protected]>
jobcloud · Dec 30, 2022 · c8bba23 · c8bba23
1 parent 5cf268b
commit c8bba23
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 11 deletions.
diff --git a/composer.json b/composer.json
@@ -11,18 +11,18 @@
         }
     ],
     "require": {
-        "php": ">=7.4",
+        "php": "^8.0",
         "ext-json": "*",
         "flix-tech/avro-php": "^3.0|^4.0",
         "jobcloud/php-kafka-schema-registry-client": "^1.0",
         "kriswallsmith/buzz": "^1.2",
         "nyholm/psr7": "^1.4",
         "pimple/pimple": "^3.2",
-        "symfony/console": "^4.3|^5.1|^6.0"
+        "symfony/console": "^5.1|^6.0"
     },
     "require-dev": {
         "infection/infection": "^0.26",
-        "phpstan/phpstan": "^0.12",
+        "phpstan/phpstan": "^1.9",
         "phpunit/phpunit": "^9.5",
         "rregeer/phpunit-coverage-check": "^0.3.1",
         "squizlabs/php_codesniffer": "^3.6"

diff --git a/docker/dev/php/Dockerfile b/docker/dev/php/Dockerfile
@@ -1,4 +1,4 @@
-FROM php:7.4-cli-alpine3.16
+FROM php:8.0-cli-alpine3.16
 
 ARG HOST_USER_ID
 

diff --git a/src/Command/CheckAllSchemaTemplatesDefaultTypeCommand.php b/src/Command/CheckAllSchemaTemplatesDefaultTypeCommand.php
@@ -88,7 +88,7 @@ private function checkSchemas(array $avroFiles, array &$failed = []): bool
 
     /**
      * @param string $localSchema
-     * @return array<string, mixed>
+     * @return array<int|string, mixed>
      */
     private function checkDefaultType(string $localSchema): array
     {
@@ -103,7 +103,7 @@ private function checkDefaultType(string $localSchema): array
     /**
      * @param mixed $decodedSchema
      * @param array<mixed, mixed> $defaultFields
-     * @return array<string, mixed>
+     * @return array<int|string, mixed>
      */
     private function checkAllFields($decodedSchema, array $defaultFields = []): array
     {
@@ -132,7 +132,7 @@ private function checkAllFields($decodedSchema, array $defaultFields = []): arra
      * @param mixed $fieldType
      * @param mixed $field
      * @param array<mixed, mixed> $defaultFields
-     * @return array<string, mixed>
+     * @return array<int|string, mixed>
      */
     private function checkSingleField($fieldType, $field, array $defaultFields): array
     {

diff --git a/src/Command/ListAllSchemasCommand.php b/src/Command/ListAllSchemasCommand.php
@@ -30,7 +30,7 @@ public function execute(InputInterface $input, OutputInterface $output): int
         $schemas = $this->schemaRegistryApi->getSubjects();
 
         foreach ($schemas as $schema) {
-            $output->writeln($schema);
+            $output->writeln((string) $schema);
         }
 
         return 0;

diff --git a/src/Command/ListVersionsForSchemaCommand.php b/src/Command/ListVersionsForSchemaCommand.php
@@ -35,7 +35,7 @@ public function execute(InputInterface $input, OutputInterface $output): int
         $schemaVersions = $this->schemaRegistryApi->getAllSubjectVersions($schemaName);
 
         foreach ($schemaVersions as $schemaVersion) {
-            $output->writeln($schemaVersion);
+            $output->writeln((string) $schemaVersion);
         }
 
         return 0;

diff --git a/src/Command/RegisterChangedSchemasCommand.php b/src/Command/RegisterChangedSchemasCommand.php
@@ -4,7 +4,6 @@
 
 use AvroSchema;
 use AvroSchemaParseException;
-use Jobcloud\Kafka\SchemaRegistryClient\Exception\SubjectNotFoundException;
 use Jobcloud\Kafka\SchemaRegistryClient\KafkaSchemaRegistryApiClientInterface;
 use Jobcloud\SchemaConsole\Helper\SchemaFileHelper;
 use Symfony\Component\Console\Input\InputArgument;
@@ -134,7 +133,7 @@ private function registerFiles(
 
             try {
                 $latestVersion = $this->schemaRegistryApi->getLatestSubjectVersion($schemaName);
-            } catch (SubjectNotFoundException $e) {
+            } catch (\Throwable $e) {
                 $latestVersion = null;
             }