Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added clock timing test #332

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

added clock timing test #332

wants to merge 2 commits into from

Conversation

hayguen
Copy link

@hayguen hayguen commented Mar 14, 2020

  • pigpio.h/.c: added API function for the test:
    test duration 50 ms, tolerance 5%
  • pigpiod: added option '-T' to (de)activate test, default: ON
  • added independent test program x_pigpio_clock,
    testing both clocks
  • amended README
  • Makefile: added targets 'test' and 'test-really'

* pigpio.h/.c: added API function for the test:
  test duration 50 ms, tolerance 5%
* pigpiod: added option '-T' to (de)activate test, default: ON
* added independent test program x_pigpio_clock,
  testing both clocks
* amended README
* Makefile: added targets 'test' and 'test-really'

Signed-off-by: hayati ayguen <[email protected]>
@hayguen
Copy link
Author

hayguen commented Mar 14, 2020

this patch is for "solving" #331

i'm unsure merge should go to master or develop?

i tested on Pi 3B+ and Pi 1.

@guymcswain
Copy link
Collaborator

@hayguen ,
First let me express my appreciation for the work you have done in this area. I think it has been a valuable learning experience for you and hopefully, with appropriate changes to the repo, will help other users of the library. That said, I need to spend time to fully evaluate what 'appropriate changes' need to be made. I don't have the time right now but I should be freed up by the end of March - I'm currently backlogged with two releases.

I'll leave you with this thought for now until I can get the bandwidth on this PR: Should more effort be put into improving the documentation on the conflicts arising from the use of audio and pigpio, if this is the root problem being addressed. As a case in point, I don't think users understand that by plugging in a an HDMI monitor they are in fact configuring the audio subsystem on the Raspberry Pi. And after users grok the fact they have indeed configured audio, a more stern caution that use of audio with pigpio requires an advanced knowledge of the library, .

@hayguen hayguen mentioned this pull request Apr 10, 2020
@guymcswain guymcswain mentioned this pull request Apr 30, 2020
@guymcswain
Copy link
Collaborator

guymcswain commented May 1, 2020

@hayguen ,
Please makex_pigpio_clock.c a stand-alone utility. I don't see the value of having a test that is integrated with all the associated file changes for such a simple diagnostic.

Also, please select develop as the base branch to merge against. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants