Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docker image and github actions autobuild #307

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jdrouet
Copy link

@jdrouet jdrouet commented Nov 29, 2019

Create a docker image for pigpiod and pushes it to the hub when done on master.
You need to put your username and password in the secrets to be able to push to docker hub.
An image is actually building on my fork for arm32v7 and arm64v8.

@guymcswain guymcswain mentioned this pull request Apr 30, 2020
@guymcswain
Copy link
Collaborator

@jdrouet ,
First, thanks for your interest in this project. However, I need your help in understanding how this is used.

I think I understand the goal of this PR is have the pigpio binaries contained in a docker image that one can download and run on their personal raspberry pi. Further, this 'github workflow' will keep those bits up to date with the latest changes - although I think it should only be triggered by a 'push' to the master branch.

Some of my confusion is around the credentials and account that is associated with the workflow. How are the credentials protected if they are hosted on this public repo? I assume the credentials must be available on this repo in order for the workflow to run automatically. If not, are you expecting that each time a push is made, the maintainers of this repo must login to the docker hub with their private account?

I probably have more questions but for now help me understand this much.

@jdrouet
Copy link
Author

jdrouet commented Oct 7, 2020

Sorry for my (really) late reply.

First, for it to push to the docker hub, the repo owner should create a docker hub account (it's free), create a token and add it as a secret int the github repository settings. Don't worry, those credentials are only injected as am environment variable on the branch on this repo. If I do a PR and do echo $DOCKER_PASSWORD, I won't be able to seen anything.

The thing to know is that github gives free credits for open source projects, so it will take from the owner's open source credit.

And you're right, we should limit what is being run. We should probably build an image for each PR without pushing it to be sure that it builds and when the branch is master, push it to the docker hub. 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants