Fixed calc_circular_pitch to use unit_factor freeing the Tooth system… #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from any specific unitary system. Previously Module was tied to millimeters while Circular and Diametral Pitch were tied to inches. Now they take their units from the Unit input just like all the other measures.
|
do you mean to claim copyright, or just be a contributer ? Just asking. |
|
Contributor status. If the copyright line was inappropriate I have no objections from removing it.
…On April 27, 2017 5:44:58 PM PDT, Neon22 ***@***.***> wrote:
do you mean to claim copyright, or just be a contributer ? Just asking.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#31 (comment)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the calc_circular_pitch function to use the declared measurements units parameter instead of static units of mm for module and inch for the others. This keeps the units of measurement used throughout the extension uniform, instead the dimension units being fixed based on the tooth system and the rest being declarative based on the units parameter. Also moved the Units parameter to the first page of the extension dialog and removed the unit designations from the tooth system option labels.
Also added the root_diameter to the annotation text so I could see the effect of the clearance parameter.