Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing for the same flag to be set multiple times when using a conf… #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

agorman
Copy link

@agorman agorman commented Jun 21, 2023

…iguration file

I'm hoping you'll consider merging this pull request that allows for multiple values for the same flag when using a configuration file. This is already something the module supports when using command line flags.

Flag example:

-arg hello -arg world

Config example:

arg hello
arg world

Thanks!

@jnovack
Copy link
Owner

jnovack commented Jun 23, 2023

The last time I touched this package was when Go was at 1.16.0. The intent is that this package -IS- the original go code with additions.

I'd be more inclined to upgrade the entire base to v1.20, THEN add in the multiple lines as part of that.

Is that something you are willing to PR? If so, I'm really keen on keeping as much of google's original code as is, and only changing the absolute bare minimum. If you look at past merges, you'll see I've made almost no modifications to original code except for what's absolutely necessary to call the new functions.

@agorman
Copy link
Author

agorman commented Jun 23, 2023

@jnovack I'm heading on vacation and I'll be gone for a week. I'll take a look at what that would entail when I return and get back to you.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants