-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interface for ptrs
pluggable transports crate
#13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
==========================================
- Coverage 73.29% 69.65% -3.64%
==========================================
Files 34 39 +5
Lines 3853 4805 +952
Branches 3853 4805 +952
==========================================
+ Hits 2824 3347 +523
- Misses 798 1094 +296
- Partials 231 364 +133 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds an interface (a set of traits) that a pluggable transport can implement to be generically interoperable.
This is not a final form commit, but more of an MVP. For example there is still a question of how the set local IPv4 and IPv6 addresses get applied. Also the exact set of mutator methods that the
{Client/Server}Transport
traits should include.For now this is good enough.
The PR includes an example
Passthrough
transport that simply returns the original stream/connection as a mock transport to test things like boxed futures and composing transports.