Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface for ptrs pluggable transports crate #13

Merged
merged 20 commits into from
Mar 18, 2024
Merged

Conversation

jmwample
Copy link
Owner

this pr adds an interface (a set of traits) that a pluggable transport can implement to be generically interoperable.

This is not a final form commit, but more of an MVP. For example there is still a question of how the set local IPv4 and IPv6 addresses get applied. Also the exact set of mutator methods that the {Client/Server}Transport traits should include.

For now this is good enough.

The PR includes an example Passthrough transport that simply returns the original stream/connection as a mock transport to test things like boxed futures and composing transports.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 54.57481% with 422 lines in your changes are missing coverage. Please review.

Project coverage is 69.65%. Comparing base (b4dcf87) to head (75cbb7c).
Report is 2 commits behind head on main.

Files Patch % Lines
crates/ptrs/src/helpers.rs 0.00% 172 Missing ⚠️
crates/ptrs/src/passthrough.rs 76.59% 24 Missing and 130 partials ⚠️
crates/obfs4/src/pt.rs 0.00% 54 Missing ⚠️
crates/obfs4/src/obfs4/client.rs 7.69% 24 Missing ⚠️
crates/obfs4/src/obfs4/server.rs 7.69% 11 Missing and 1 partial ⚠️
crates/ptrs/src/lib.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   73.29%   69.65%   -3.64%     
==========================================
  Files          34       39       +5     
  Lines        3853     4805     +952     
  Branches     3853     4805     +952     
==========================================
+ Hits         2824     3347     +523     
- Misses        798     1094     +296     
- Partials      231      364     +133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmwample jmwample merged commit b5bf749 into main Mar 18, 2024
6 of 8 checks passed
@jmwample jmwample deleted the ptrs-interface branch March 18, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant