This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Feature/marking payment as paid #270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the swagger contract to make marking payment as paid possible - Added a bit of test data to the data.sql file - Fixed the java version number in the Dockerfile since it was causing errors building the project - Developed the paid payment feature
boisvertmathieu
commented
Oct 2, 2022
| @@ -1384,6 +1407,9 @@ components: | |||
| type: number | |||
| dueDate: | |||
| type: string | |||
| paid: | |||
There was a problem hiding this comment.
One thing that could be done better here would be to add an allOf reference to a Payment schema for both the MemberPayment and AdminPayment schema here. Since there was already a Payment entity class in the code, I wasn't really sure what to name the new schema, so I decided to just add the new field in both object.
| @@ -26,12 +26,14 @@ | |||
| @Getter | |||
| @Setter | |||
| public class PaymentDto { | |||
| private Long id; | |||
There was a problem hiding this comment.
Adding this id here helps updating the payment entity in the PaymentSDJpaService
| @@ -21,6 +21,4 @@ | |||
|
|
|||
| public interface PaymentRepository extends JpaRepository<Payment, Long> { | |||
| Optional<Payment> findByPaymentId(String paymentId); | |||
|
|
|||
| void deleteByPaymentId(String paymentId); | |||
There was a problem hiding this comment.
This method wasn't used.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
Added the "marking payment as paid" feature that was listed in the
assets/FEATURES.mdfile. We can mark a payment as paid by calling the/payments/{PAYMENT_ID}/paidendpoint with aPATCHrequest. I modified the postman collection and added some test data to thedata.sqlfile to be able to test the new feature.📄 Motivation and Context
This change was listed as being a future feature that was going to be implemented.
🧪 How Has This Been Tested?
I added tests in the
PaymentControllerTest.javaclass and in thePaymentSDJpaServiceTest.javaclass to cover the code I added. I checked the jacoco report, and my modifications are (normally) 100% covered. I did not add any integration tests in the integration-tests module.I also added a request in the postman collection to test the change, while connecting to the h2 database on the
/h2-consoleendpoint. After I executed the said request, I saw that the payment that I was trying to mark as paid got updated successfully.📷 Screenshots (if appropriate)
📦 Types of changes
✅ Checklist