Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manifest.json: update homepage_url #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

manifest.json: update homepage_url #41

wants to merge 1 commit into from

Conversation

blueyed
Copy link

@blueyed blueyed commented Jan 26, 2020

Ref: #39

@blueyed
Copy link
Author

blueyed commented Jan 26, 2020

Note that it is also referenced in

compactheader/build.xml

Line 6 in 77b4035

<property name="mozdev.dir" value="${src.dir}/../../workspace/compactheader.mozdev.org"/>
, but that should likely be kept?

Cai0407
Cai0407 reviewed Jan 26, 2020
View reviewed changes
Copy link
Contributor

@Cai0407 Cai0407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to link to ATN, not to AMO.

https://addons.thunderbird.net/thunderbird/addon/compactheader/

Link on github top page also need to be updated.

@blueyed
Copy link
Author

blueyed commented Jan 26, 2020

Thanks.

Link on github top page also need to be updated.

Yeah, that's the one I've used.

@blueyed blueyed force-pushed the update-homepage_url branch from 77b4035 to 75f81f7 Compare January 26, 2020 18:58
@jmozmoz
Copy link
Owner

jmozmoz commented Jan 26, 2020

Thanks.

Link on github top page also need to be updated.

Yeah, that's the one I've used.

Which link on which page do you mean?

@blueyed
Copy link
Author

blueyed commented Jan 26, 2020

At the top of https://github.com/jmozmoz/compactheader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cai0407 Cai0407 Cai0407 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blueyed @jmozmoz @Cai0407