Add file extension to custom path part #344
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for the PR. Looks good to me. Before merging it would be great to have a unit test that verifies this functionality so we don't break it in the future. Let me know if that's not something you feel comfortable doing. |
|
Sorry for the late reply. I'm more than happy to add some unit test for it. Can you point me to the file that does the test for the other parameters in that function? I think it would make sense to have them all in one place, but I don't know the code base well enough. |
|
Thanks. Here is an example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, thanks for your effort in creating this project! I had halfway started something similar on my own some time ago and abandoned it due to time constraints. What you have done here is way more advanced than what I had accomplished before giving up.
The pull request addresses #271 at least the extension part. I wasn't interested in going further than that but I also felt sad that this IMHO very useful enhancement didn't result in a pull request at the end of it so here it is.
I can also verify that it works as indicated.
EDIT: Btw, I'm more than happy adding a test for this but I wasn't sure if/where/how you are testing for such things. If you point me in the right direction then I can add that to the pull request.