Skip to content

Conversation

@ruhulio
Copy link
Contributor

@ruhulio ruhulio commented Sep 23, 2025

Description

Add basic Redis storage support that surfaces common settings and parameters.

There really wasn't any useful unit tests to add since the heavy lifting is all done by the underlying Redis client which when mocked is effectively testing almost nothing.

I did verify the functionality manually by running a local and remote Redis instance, e.g. docker run -p 6379:6379 -it redis:latest.

As KVStorage is a new feature with only a mention in the OAuthProxy documentation as part of client_storage, I wasn't sure where docs for a new implementation of the protocol should be added. Happy to add something if pointed to the appropriate spot.

Contributors Checklist

Review Checklist

  • I have self-reviewed my changes
  • My Pull Request is ready for review

@marvin-context-protocol marvin-context-protocol bot added the enhancement Improvement to existing functionality. For issues and smaller PR improvements. label Sep 23, 2025
@strawgate
Copy link
Collaborator

As mentioned in #1896 I'd like to fit this into the broader change we might be making to kv caches

@jlowin
Copy link
Owner

jlowin commented Sep 25, 2025

@ruhulio really appreciate this but going to close in favor of #1913 as we're abstracting all storage into another package!

@jlowin jlowin closed this Sep 25, 2025
@ruhulio
Copy link
Contributor Author

ruhulio commented Sep 25, 2025

@ruhulio really appreciate this but going to close in favor of #1913 as we're abstracting all storage into another package!

Yep, that works for me.

@ruhulio ruhulio deleted the ruhul/basic-redis-storage branch September 25, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvement to existing functionality. For issues and smaller PR improvements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Redis support for the KVStorage protocol

3 participants