feat: Add basic Redis storage support #1897
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add basic
Redisstorage support that surfaces common settings and parameters.There really wasn't any useful unit tests to add since the heavy lifting is all done by the underlying
Redisclient which when mocked is effectively testing almost nothing.I did verify the functionality manually by running a local and remote
Redisinstance, e.g.docker run -p 6379:6379 -it redis:latest.As
KVStorageis a new feature with only a mention in theOAuthProxydocumentation as part ofclient_storage, I wasn't sure where docs for a new implementation of the protocol should be added. Happy to add something if pointed to the appropriate spot.Contributors Checklist
Review Checklist