Fix strict Argument checking broken with relative completion offset#202
Open
tkruse wants to merge 2 commits intojline:masterfrom
tkruse:aggregate-bug
Open
Fix strict Argument checking broken with relative completion offset#202tkruse wants to merge 2 commits intojline:masterfrom tkruse:aggregate-bug
tkruse wants to merge 2 commits intojline:masterfrom
tkruse:aggregate-bug
Conversation
Contributor
Author
|
I found another problem if the candidate has a delimiter appended. Fixed that, but the code looks bloated. Not sure if anyone can find a more elegant solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a small regression in ArgumentCompleter when one of the involved completers returns a partial completion (meaning one with an offset. I believe this was introduced here:
2de5902