Skip to content

Fix strict Argument checking broken with relative completion offset#202

Open
tkruse wants to merge 2 commits intojline:masterfrom
tkruse:aggregate-bug
Open

Fix strict Argument checking broken with relative completion offset#202
tkruse wants to merge 2 commits intojline:masterfrom
tkruse:aggregate-bug

Conversation

@tkruse
Copy link
Contributor

@tkruse tkruse commented Aug 11, 2015

I found a small regression in ArgumentCompleter when one of the involved completers returns a partial completion (meaning one with an offset. I believe this was introduced here:

2de5902

-            if (subCandidates.size() == 0) {
+            if (!subCandidates.contains(arg)) {

@tkruse
Copy link
Contributor Author

tkruse commented Aug 11, 2015

I found another problem if the candidate has a delimiter appended. Fixed that, but the code looks bloated. Not sure if anyone can find a more elegant solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant