Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maximum call stack size exceeded in some case #438

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Camork
Copy link

@Camork Camork commented Jul 14, 2023

I found some stackoverflow bugs when import a customized format with a very deep recursion. There are another similar report , but I can only fix my cases.

@jlfwong
Copy link
Owner

jlfwong commented Jul 14, 2023

Hi @Camork!

Can you share more about how the stack overflow was was being produced in the first place? Is this a profile you produced where the actual stack depth of the profile itself was in the hundred to thousands?

@Camork
Copy link
Author

Camork commented Jul 14, 2023

We have implement a format in our own , it records the function call, and use the CallTreeProfileBuilder to build the ProfileGroup . The format composed by the'call' and 'return' like function.

Is this a profile you produced where the actual stack depth of the profile itself was in the hundred to thousands?

Yes, we have record a application which do recursion call about thirty thousand mostly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants