Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move NamedArrayPartition back to StartUpDG.jl (temporarily) #175

Merged
merged 3 commits into from
Jun 29, 2024

Conversation

jlchan
Copy link
Owner

@jlchan jlchan commented Jun 28, 2024

This PR moves NamedArrayPartition back to StartUpDG.

This is done in order to deal with compatibility issues related to trixi-framework/Trixi.jl#1789, which required Trixi to restrict DiffEqBase, which in turn restricts RecursiveArrayTools.jl and prevents us from using version > 3.4.0 (when NamedArrayPartition was moved from StartUpDG.jl).

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.93%. Comparing base (e011af6) to head (40735e1).

Current head 40735e1 differs from pull request most recent head f8e379d

Please upload reports for the commit f8e379d to get more accurate results.

Files Patch % Lines
src/named_array_partition.jl 94.44% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
- Coverage   95.96%   95.93%   -0.03%     
==========================================
  Files          27       28       +1     
  Lines        3763     3817      +54     
==========================================
+ Hits         3611     3662      +51     
- Misses        152      155       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlchan jlchan merged commit 8a27d8d into main Jun 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant