Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subcell finite volume differencing and reconstruction operators #163

Merged
merged 22 commits into from
May 22, 2024

Conversation

jlchan
Copy link
Owner

@jlchan jlchan commented Mar 26, 2024

Adds the multi-diimensional equivalent of the sparse subcell operators in Lin, Chan (2024) (see also https://doi.org/10.1016/j.jcp.2023.112677)

Also improves docs and robustness of sparse subcell SBP operators.

@jlchan jlchan marked this pull request as draft March 26, 2024 02:13
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 95.48872% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 92.80%. Comparing base (2c56f42) to head (f387929).
Report is 29 commits behind head on dev.

Current head f387929 differs from pull request most recent head c2e3654

Please upload reports for the commit c2e3654 to get more accurate results.

Files Patch % Lines
src/low_order_sbp.jl 95.83% 5 Missing ⚠️
src/ref_elem_utils.jl 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #163      +/-   ##
==========================================
- Coverage   97.12%   92.80%   -4.33%     
==========================================
  Files          25       27       +2     
  Lines        3167     3766     +599     
==========================================
+ Hits         3076     3495     +419     
- Misses         91      271     +180     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlchan jlchan changed the base branch from main to dev May 1, 2024 02:45
@jlchan jlchan changed the title Improve sparse subcell SBP operators Add subcell finite volume differencing and reconstruction operators May 17, 2024
@jlchan jlchan marked this pull request as ready for review May 22, 2024 02:39
@jlchan jlchan merged commit 8d21c88 into dev May 22, 2024
8 checks passed
@jlchan jlchan mentioned this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant