Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor intra process nodes and standard nodes, to share a common codebase #16

Open
horverno opened this issue Dec 3, 2024 · 1 comment
Open

Refactor intra process nodes and standard nodes, to share a common codebase #16

horverno opened this issue Dec 3, 2024 · 1 comment
Assignees
@Zahuczky @umiklos
Labels
gamma Gamma Komondor related refactor Refactor existing code usually for easier maintainability

Comments

@horverno
Copy link
Member

horverno commented Dec 3, 2024

Refactor the nodes so they don't duplicate the code

Following #11

Good example is Patchwork
@horverno horverno added gamma Gamma Komondor related refactor Refactor existing code usually for easier maintainability labels Dec 3, 2024
@horverno horverno changed the title Refactor Refactor intra process nodes and standard nodes, to share a common codebase Dec 3, 2024
@horverno horverno moved this to Todo in ROS2 Lexus Jan 6, 2025
@horverno horverno moved this from Todo to In Progress in ROS2 Lexus Jan 21, 2025
@horverno
Copy link
Member Author

Refactor the code to eliminate redundancy by creating a shared implementation that both euclidean_grid_composable.cpp and euclidean_grid.cpp can use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zahuczky Zahuczky

@umiklos umiklos

Labels
gamma Gamma Komondor related refactor Refactor existing code usually for easier maintainability
Projects
ROS2 Lexus
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Zahuczky @horverno @umiklos