Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch tracker urls #38

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 19 additions & 12 deletions lib/tracking_number/base.rb
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,24 @@ def self.scan(body)
end
end

def self.tracking_url(*trackers)
if not trackers.all? { |t| t.class == self }
raise ArgumentError, "all tracking numbers must be of same class"
end
url = nil
courier = trackers.first.matching_additional["Courier"]
if courier
url = courier[:tracking_url]
else
if self.const_defined?(:TRACKING_URL)
url = self.const_get(:TRACKING_URL)
end
end
if url
url.sub('%s', trackers.map(&:tracking_number).join(','))
end
end

def serial_number
return match_group("SerialNumber") unless self.class.const_get("VALIDATION")

Expand Down Expand Up @@ -170,18 +188,7 @@ def shipper_id
end

def tracking_url
url = nil
if matching_additional["Courier"]
url = matching_additional["Courier"][:tracking_url]
else
if self.class.const_defined?(:TRACKING_URL)
url = self.class.const_get(:TRACKING_URL)
end
end

if url
url.sub('%s', self.tracking_number)
end
self.class.tracking_url self
end

def matching_additional
Expand Down