Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comments colours #184

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

soshial
Copy link
Contributor

@soshial soshial commented Jan 5, 2024

Intellij Light (all are grey):
Screenshot 2024-01-05 at 18 29 38

Argument 1:

According to the official documentation the comments should be of base1 colour #93a1a1:
image

Argument 2:

An example for Java(Vim) from the official documentation:

image

Before this PR change:

  • different colours
  • block comment colour is too similar to main text colour and is #657b83 which is base00 colour
  • line comment is red for some reason
Screenshot 2024-01-05 at 18 30 03

This PR changes to this:

  • all comment colours have unified light grey look
Screenshot 2024-01-05 at 18 59 52

@jkaving
Copy link
Owner

jkaving commented Jan 5, 2024

The comment colors was discussed quite a bit back in #67, #127, #152 and #155.

From #155:

To summarise it:

  • Yes, it is intentional
  • Javadoc comments are grey (or green, for Solarized Light) to be more unobtrusive
    This is a difference from the original Solarized theme where Javadoc comments are red
  • Line comments are red - to stand out more (argued for in this article)

Perhaps a section about intentional differences from the original Solarized should be added to the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants