Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: incrementally upgrade to nextjs app router #1513

Merged
merged 22 commits into from
Apr 4, 2024

Conversation

nakedfool
Copy link
Contributor

@nakedfool nakedfool commented Apr 2, 2024

Closes #1483

We are currently stuck with this issue rainbow-me/rainbowkit#1777, once we resolve it, i'll bring back connectors and pack this PR.

Small issues we are left with:

  • Move /api into the /app
  • Resolve document.tsx in /app
  • Bring back our original connectors

We are blocked at this moment with the last item, the only solution here is to use list of connectors from the wagmi https://wagmi.sh/react/api/connectors#available-connectors

We have 2 wagmi config files now, one that we pass to the client-side components and one for the server-side components, issue is that we cannot pass a wagmi config file with rainbowkit connectors to the server-side components, therefore, whenever we do anything related to the contracts in the server-side component, we would use wagmi server config.

@nakedfool nakedfool added the chore A maintenance update label Apr 2, 2024
@nakedfool nakedfool marked this pull request as ready for review April 4, 2024 14:32
Copy link
Member

@siobh9 siobh9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nakedfool nakedfool merged commit 676708a into staging Apr 4, 2024
2 checks passed
@nakedfool nakedfool deleted the chore/upgrade-nextjs-to-app-router branch April 4, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A maintenance update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: upgrade nextjs from page router to app router
2 participants