Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: replace outdated claim about lacking git blame support #5192

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

keanemind
Copy link
Contributor

@keanemind keanemind commented Dec 26, 2024

Addresses #5191

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

Copy link

google-cla bot commented Dec 26, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@arxanas
Copy link
Contributor

arxanas commented Dec 26, 2024

^ re CLA see #4849

@keanemind
Copy link
Contributor Author

Whoops, just signed it. Any thoughts on the new wording I used?

@keanemind
Copy link
Contributor Author

keanemind commented Dec 28, 2024

Oh something looks off about the commit, I think my auto formatter for Markdown kicked in

Edit: fixed

Copy link
Contributor

@arxanas arxanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, thanks!

@PhilipMetzger PhilipMetzger merged commit 7402362 into jj-vcs:main Dec 29, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants