show untracked files in jj status #5138
Open
+96
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstoitner
force-pushed
the
status_untracked
branch
from
213f80a to
433e28d
Compare
yuja
reviewed
Dec 19, 2024
| // TODO: Report this path to the caller | ||
| self.untracked_paths_tx | ||
| .send((path, UntrackedReason::FileNotAutoTracked)) | ||
| .ok(); |
There was a problem hiding this comment.
Just reminder: we also need to report untracked directories containing untracked files, but that can be addressed separately.
There was a problem hiding this comment.
I will be out of town over the weekend and I'm not sure how much time a will have next week, so it might be a while before I get to that.
| @@ -85,6 +87,14 @@ pub(crate) fn cmd_status( | |||
| )?; | |||
| } | |||
|
|
|||
| formatter.with_label("diff", |formatter| { | |||
There was a problem hiding this comment.
nit: can you leave a TODO comment about watchman somewhere?
See 168c797 for the issue.
… tracked because of snapshot.auto-track
cstoitner
force-pushed
the
status_untracked
branch
from
433e28d to
f891e16
Compare
martinvonz
reviewed
Dec 20, 2024
| @@ -258,6 +258,8 @@ pub enum UntrackedReason { | |||
| /// Maximum allowed size. | |||
| max_size: u64, | |||
| }, | |||
| /// Setting snapshot.auto-track did not match this file. | |||
There was a problem hiding this comment.
nit: I initially parsed "Setting" as a verb. Maybe "Setting" -> "Config"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the plumbing to get the untracked files from the snapshot to the status command and displays them similar to mercurial. I am not sure if this is the right way to do this.
This might be the last thing to fix #323.
Checklist
If applicable:
CHANGELOG.md