tests: split cli/tests to separate crate, remove test-fakes feature (PoC) #4622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuja
force-pushed
the
push-wkuoyunotwuo
branch
from
7e5f12e to
61fe27b
Compare
yuja
force-pushed
the
push-wkuoyunotwuo
branch
from
61fe27b to
646ba5a
Compare
yuja
force-pushed
the
push-wkuoyunotwuo
branch
from
646ba5a to
a007234
Compare
This fixes real dependency cycle that would expose slightly different versions of jj_lib types to unit tests, one from super::* and another from testutils::*. The testutils dependency will be removed by splitting lib/tests to a separate crate.
This breaks dev-dependency cycle: jj-lib -> testutils -> jj-lib. I put Cargo.toml in lib/tests so the directory structure looks familiar. I'm not sure if this layout is common, but I found this pattern in gix.
…PoC) The goal is to remove the crate-cycle: `jj-cli --(dev)--> jj-cli`. Since there's no way to express binary dependency in Cargo.toml, all binaries which the tests depend on should have to be built within the same crate. I put Cargo.toml in cli/tests so the directory structure looks familiar. One big caveat: since we build a separate "jj" binary for tests, the production "jj" binary is no longer covered by these tests. We might want to leave a couple of tests in jj-cli to ensure that the real "jj" binary works.
yuja
force-pushed
the
push-wkuoyunotwuo
branch
from
a007234 to
ac77261
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to remove the crate-cycle:
jj-cli --(dev)--> jj-cli. Since there's no way to express binary dependency in Cargo.toml, all binaries which the tests depend on should have to be built within the same crate.I put Cargo.toml in cli/tests so the directory structure looks familiar.
One big caveat: since we build a separate "jj" binary for tests, the production "jj" binary is no longer covered by these tests. We might want to leave a couple of tests in jj-cli to ensure that the real "jj" binary works.
Checklist
If applicable:
CHANGELOG.md