cli new
: Allow --before/--after
without a value to default to @
#4551
+119
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, I find it a bit jarring that
jj new
works butjj new --before
does not. By contrast, sincejj rebase
does not currently work, I don't thinkjj rebase --before
should either.Note that
jj new --before @ another_revision
is invalid, sojj new --before another_revision
can only be parsed correctly in one way. I am slightly concerned thatclap
might forbids this in the future even in the cases where a human can tell there is no ambiguity, but I'm hoping for the best.Checklist
If applicable:
CHANGELOG.md