Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow docker tag to be specified as parameter in Makefile #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −2
Open

feat: allow docker tag to be specified as parameter in Makefile #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ endif
GIT_HASH ?= $(shell git rev-parse --short HEAD)
PLATFORMS ?= linux/amd64
CACHE_DIR ?= /tmp/docker-cache
DOCKER_TAG ?= ${GIT_HASH}

_login:
${DOCKER_LOGIN_CMD}
Expand All @@ -18,7 +19,7 @@ build-summaries : _login
--platform ${PLATFORMS} \
--cache-from type=local,src=${CACHE_DIR} \
--cache-to type=local,dest=${CACHE_DIR},mode=max \
-t ${IMAGE_REGISTRY}/skynet:summaries-${GIT_HASH} .
-t ${IMAGE_REGISTRY}/skynet:summaries-${DOCKER_TAG} .

build-whisper : _login
docker buildx build \
Expand All @@ -29,4 +30,4 @@ build-whisper : _login
--push \
--cache-from type=local,src=${CACHE_DIR} \
--cache-to type=local,dest=${CACHE_DIR},mode=max \
-t ${IMAGE_REGISTRY}/skynet:whisper-${GIT_HASH} .
-t ${IMAGE_REGISTRY}/skynet:whisper-${DOCKER_TAG} .