feat(transcription): Slow down leaving participants. #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slow down events internally in the transcriber, so we give time for the service to return any pending transcriptions. We also wait for all leave processing to finish before transcriber leaves the room, so any sent transcriptions to be processed.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #528 +/- ##
============================================
- Coverage 20.86% 20.49% -0.37%
+ Complexity 289 287 -2
============================================
Files 74 76 +2
Lines 6222 6313 +91
Branches 833 838 +5
============================================
- Hits 1298 1294 -4
- Misses 4699 4801 +102
+ Partials 225 218 -7
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
rpurdel
approved these changes
Mar 19, 2024
bgrozev
previously approved these changes
Mar 19, 2024
| /** | ||
| * The thread pool to serve all leave operations. | ||
| */ | ||
| private static final ScheduledExecutorService leaveThreadPool = Executors.newScheduledThreadPool( |
There was a problem hiding this comment.
The operation shouldn't be time-consuming and this is for the whole jigasi all meetings, not a strong reason.
| // give some time for the transcriptions for this participant to be ready | ||
| leaveThreadPool.schedule(() -> | ||
| { | ||
| this.transcriber.participantLeft(identifier); |
There was a problem hiding this comment.
What if this throws? Maybe just decrement the counter beforehand?
bgrozev
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slow down events internally in the transcriber, so we give time for the service to return any pending transcriptions. We also wait for all leave processing to finish before transcriber leaves the room, so any sent transcriptions to be processed.