Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest_long as the default google ts model #526

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

rpurdel
Copy link
Contributor

@rpurdel rpurdel commented Mar 11, 2024

No description provided.

@saghul
Copy link
Member

saghul commented Mar 11, 2024

Can't we make this a config option, defaulting to that new model? It feels like it would make experimenting easier.

@rpurdel
Copy link
Contributor Author

rpurdel commented Mar 11, 2024

Can't we make this a config option, defaulting to that new model? It feels like it would make experimenting easier.

Done

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 20.70%. Comparing base (86273ae) to head (38fe12e).
Report is 12 commits behind head on master.

❗ Current head 38fe12e differs from pull request most recent head 368f5b9. Consider uploading reports for the commit 368f5b9 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #526      +/-   ##
============================================
- Coverage     20.86%   20.70%   -0.16%     
  Complexity      289      289              
============================================
  Files            74       76       +2     
  Lines          6222     6302      +80     
  Branches        833      835       +2     
============================================
+ Hits           1298     1305       +7     
- Misses         4699     4777      +78     
+ Partials        225      220       -5     
Files Coverage Δ
...transcription/GoogleCloudTranscriptionService.java 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71b8a91...368f5b9. Read the comment docs.

saghul
saghul previously approved these changes Mar 11, 2024
bgrozev
bgrozev previously approved these changes Mar 11, 2024
@damencho damencho changed the title JIT-12948 latest_long as the default google ts model latest_long as the default google ts model Mar 19, 2024
@rpurdel rpurdel dismissed stale reviews from bgrozev and saghul via 368f5b9 March 20, 2024 09:03
@damencho damencho merged commit 551ae20 into jitsi:master Mar 20, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants